Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][query] Remove bifurcation for grpc query server #6145

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[fix][query] Remove bifurcation for grpc query server #6145

merged 1 commit into from
Oct 31, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Oct 31, 2024 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • This PR removes the bifurcation in the creation of the GRPC query server. This bifurcation was initially added to handle the case where users were leveraging the same port for starting both the GRPC and HTTP query servers. However, that part is handled by initListener and not at the time of creating the server, so we can simply use OTEL's helper to create the server while leaving our logic to start the listeners using cmux if the ports are the same.

How was this change tested?

  • CI

Checklist

@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 31, 2024 22:40
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (4f5eca1) to head (d144eeb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6145      +/-   ##
==========================================
+ Coverage   96.42%   96.48%   +0.06%     
==========================================
  Files         353      353              
  Lines       20141    20107      -34     
==========================================
- Hits        19420    19401      -19     
+ Misses        534      522      -12     
+ Partials      187      184       -3
Flag Coverage Δ
badger_v1 8.32% <ø> (ø)
badger_v2 1.68% <ø> (ø)
cassandra-4.x-v1 14.40% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.40% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.53% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.60% <ø> (ø)
elasticsearch-8.x-v1 18.78% <ø> (ø)
elasticsearch-8.x-v2 1.67% <ø> (-0.02%) ⬇️
grpc_v1 9.50% <ø> (ø)
grpc_v2 7.01% <ø> (ø)
kafka-v1 8.89% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.68% <ø> (ø)
opensearch-1.x-v1 18.66% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.66% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.39% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 946bdbc into jaegertracing:main Oct 31, 2024
50 of 51 checks passed
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
@yurishkuro
Revert "[fix][query] Remove bifurcation for grpc query server (jaeger…
d6ba2c6 
…tracing#6145)"

This reverts commit 946bdbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[query] Switch to use OTEL's http/grpc servers
2 participants
@mahadzaryab1 @yurishkuro